refactor(member): 활동 3차 QA 피드백 반영 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54c22ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gwansikk
requested changes
Sep 21, 2024
apps/member/src/components/group/ActivityParticipantEditor/ActivityParticipantEditor.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+232
to
+237
| const days = Math.floor(second / (24 * 3600)); | ||
| const hours = Math.floor((second % (24 * 3600)) / 3600); | ||
| const minutes = Math.floor((second % 3600) / 60); | ||
| const seconds = second % 60; | ||
|
|
||
| return `${days}일 ${hours}시간 ${minutes}분 ${seconds}초 늦었어요.`; |
There was a problem hiding this comment.
dayjs format 함수를 사용하면 편리하게 해당 포맷으로 전환할 수 있어요
There was a problem hiding this comment.
const formattedDate = dayjs('0000-00-00 00:00:00')
.add(days, 'day')
.add(hours, 'hour')
.add(minutes, 'minute')
.add(seconds, 'second')
.format('DD일 HH시간 mm분 ss초 늦었어요');로 작성하였더니 day에 30일이 자동으로 들어가져서요 😹
마감 기한의 날짜를 넘기지 않고 시간만 넘겨진 경우에 00일 00시간 11분 1초 늦었어요. 이렇게 표시 되지 않고 30일 00시간 11분 1초 늦었어요라고 나타나요. 시간에서 month와 day는 0이 될 수 없어서 그렇게 나타나는 것 같아요. 혹시 다른 방법 생각하셨을까요?
Comment on lines
31
to
33
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.END), | ||
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.PROGRESSING), | ||
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.WAITING), |
There was a problem hiding this comment.
Suggested change
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.END), | |
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.PROGRESSING), | |
| ACTIVITY_QUERY_KEY.STATUSES_PAGES(ACTIVITY_STATE.WAITING), |
ACTIVITY_QUERY_KEY.STATUSES_PAGES의 상위 키인 ACTIVITY_QUERY_KEY.STATUSES를 invaildate를 한다면 하위 키는 같이 invaildate가 돼요
apps/member/src/pages/GroupAssignmentPage/GroupAssignmentPage.tsx
Outdated
Show resolved
Hide resolved
SWARVY
approved these changes
Sep 21, 2024
Comment on lines
138
to
144
| <div key={file.fileUrl} className="mx-auto flex flex-col gap-2 "> | ||
| <File | ||
| href={file.fileUrl} | ||
| name={file.originalFileName} | ||
| key={file.fileUrl} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| <div key={file.fileUrl} className="mx-auto flex flex-col gap-2 "> | |
| <File | |
| href={file.fileUrl} | |
| name={file.originalFileName} | |
| key={file.fileUrl} | |
| /> | |
| </div> | |
| <div key={file.fileUrl} className="mx-auto flex flex-col gap-2 "> | |
| <File | |
| href={file.fileUrl} | |
| name={file.originalFileName} | |
| /> | |
| </div> |
별건 아니지만 key가 두개일 필요는 따로 없어보이네요
gwansikk
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
운영진 대상으로 진행된 3차 활동 QA를 바탕으로 코드를 개선합니다.
Tasks
toastinput초기화message수정_일 _시간 _분 _초 늦었어요.로 표시GroupCard이미지 깨지는 문제 보완ETC
22일 일요일 오전 배포 목표로 후다닥 작업해서 부족한 점이 많을 수 있어요,,, 😥
Screenshot